[PATCH] spi-orion: add device tree binding

Arnd Bergmann arnd at arndb.de
Mon Jul 23 13:43:13 EDT 2012


On Monday 23 July 2012, Mark Brown wrote:
> On Mon, Jul 23, 2012 at 12:59:45PM +0200, Andrew Lunn wrote:
> > On Mon, Jul 23, 2012 at 11:43:34AM +0100, Mark Brown wrote:
> > > On Mon, Jul 23, 2012 at 12:08:09PM +0200, Andrew Lunn wrote:
> 
> > > > +Optional properties:
> > > > +- interrupts : Is currently not used.
> 
> > > Would it not be better to just omit this if it doesn't do anything and
> > > doesn't have any semantics defined?
> 
> > I was specifically asked to include this, which is why it appeared in
> > v2, not the first version. I forget who it was who asked for it, maybe
> > Arnd Bergmann? I can dig through my email archive if you want to know.
> 
> If you're going to include it you should define some sematics for it.
> You could define an optional "yohNg1ai" property too...

Agreed. I'm rather sure I did not ask for an unused property to be
documented. However, the documentation should definitely match the
example and the what kinds of properties are used in the device tree.

If the device has an interrupt that is not used by Linux, I would
document what the interrupt is for.

	Arnd



More information about the linux-arm-kernel mailing list