[PATCH v2 1/2] USB: chipidea: add imx usbmisc support
richard.zhao at freescale.com
Mon Jul 23 07:45:08 EDT 2012
On Mon, Jul 23, 2012 at 02:21:06PM +0300, Felipe Balbi wrote:
> On Mon, Jul 23, 2012 at 07:13:52PM +0800, Richard Zhao wrote:
> > On Mon, Jul 23, 2012 at 01:51:55PM +0300, Felipe Balbi wrote:
> > > On Mon, Jul 23, 2012 at 11:30:18AM +0200, Marc Kleine-Budde wrote:
> > > > On 07/23/2012 11:27 AM, Richard Zhao wrote:
> > > > >> This patch looks like a recipe for disaster IMHO, but it's Alex's call.
> > > > > Well, if there's any better place to hold it, I'd like to move there.
> > > > > Another place is arch/arm/mach-imx. Sascha/Shawn who are maintainers of
> > > > > imx are also in cc list.
> > > >
> > > > IMHO it's not about the place where the driver is located, it's about
> > > > the shortcomings Michael and Sascha mentioned.
> > Thanks, Marc.
> > >
> > > exactly. It's not about where a file is placed or how it's called. It's
> > > how you decided to implement it. This will prevent a platform with
> > > multiple instances of the IP to be used, at least.
> > To me, usbmisc on imx6 is just a set of non-core registers which is
> > companion of Chipidea IP cores. All cores share the same usbmisc.
> > From design perspective, ci13xxx_imx knows nothing about usbmisc. It
> > just call the ops in proper occasion. usbmisc driver wrappers all
> > SoC specific things.
> but if all you need is to call and initialization function, why don't
> you just do it on probe() of that usbmisc stuff ? Is this usbmisc used
> only for this USB IP ?
If it only need to init once, it may follow that way. But it also have
remote wakeup enable/disable bits, which in Freescale internal driver,
are set enabled or disabled at runtime.
More information about the linux-arm-kernel