[PATCH RESEND 1/4] ARM: OMAP2+: AM33XX: Add tps65910 device tree data

AnilKumar, Chimata anilkumar at ti.com
Mon Jul 23 03:06:48 EDT 2012


On Fri, Jul 20, 2012 at 17:08:06, Mark Brown wrote:
> On Fri, Jul 20, 2012 at 11:27:36AM +0000, AnilKumar, Chimata wrote:
> > On Fri, Jul 20, 2012 at 15:29:36, Mark Brown wrote:
> 
> > > Every regulator here has a rather large voltage range specified with no
> > > consumers added.  Are you sure these voltage ranges make sense in your
> > > design and you've not just cut'n'pasted the entire voltage range that
> > > your regulator supports without reference to what your board can do?
> 
> > tps65217.dtsi is a generic file to be used by the SoCs so these constraints
> > were taken from the regulator itself. SoC specific limits can be added in
> > SoC specific .dts file to tighten the constraints to require limit. I have
> > tested the driver with this approach.
> 
> No, this is not a sane approach.  You've no idea if any of these
> settings are safe or sane for the board.  Boards should enable things
> they know are safe, not remove those they know are broken.
> 

Unsterstood, I will send v2 with constraints updated.

Regards
AnilKumar


More information about the linux-arm-kernel mailing list