[alsa-devel] [PATCH 1/4] ASoC: mxs-saif: fix clock prepare and enable unbalance issue

Shawn Guo shawn.guo at linaro.org
Sat Jul 21 03:03:49 EDT 2012


On Fri, Jul 20, 2012 at 05:20:24PM +0800, Dong Aisheng wrote:
> From: Dong Aisheng <dong.aisheng at linaro.org>
> 
> Currently we directly call a clock_enable in trigger function without
> a clk_prepare as pair first.
> This will cause system hang immediately when run capture because
> the clock was not prepared(playback does not hang because the clock was
> prepared already by get_mclk before), a warning message in clock framework
> may cause a deadlock to reclaim clock lock (see: pl011_console_write).
> 
> Here we prepare clock first in hw_param, then enable it in trigger
> function to guarantee the balance.
> 
> Cc: Mark Brown <broonie at opensource.wolfsonmicro.com>
> Cc: Liam Girdwood <lrg at ti.com>
> Cc: Wolfram Sang <w.sang at pengutronix.de>
> Cc: Shawn Guo <shawn.guo at linaro.org>

Acked-by: Shawn Guo <shawn.guo at linaro.org>




More information about the linux-arm-kernel mailing list