[RFC PATCH v2] ARM: Make a compile firmware conditionally

[Kyungmin Park]

On 7/20/12, Arnd Bergmann <arnd at arndb.de> wrote:
> On Monday 16 July 2012, Kyungmin Park wrote:
>> From: Kyungmin Park <kyungmin.park at samsung.com>
>>
>> Some boards can use the firmware at trustzone but others can't use this.
>> However we need to build it simultaneously. To address this issue,
>> introduce arm firmware support and use it at each board files.
>>
>> e.g., In boot_secondary at mach-exynos/platsmp.c
>>
>>         __raw_writel(virt_to_phys(exynos4_secondary_startup),
>>                 CPU1_BOOT_REG);
>>
>>         if (IS_ENABLED(CONFIG_ARM_FIRMWARE)) {
>>                 /* Call Exynos specific smc call */
>> 		firmware_ops.cpu_boot(cpu);
>>         }
>>
>>         gic_raise_softirq(cpumask_of(cpu), 1);
>>
>>         if (pen_release == -1)
>>
>> Now smp_ops is not yet merged, now just call the firmware_init at
>> init_early
>>  at board file
>>
>> e.g., exynos4412 based board
>>
>> static void __init board_init_early(void)
>> {
>> 	exynos_firmware_init();
>> }
>>
>> TODO
>> 	1. DT support.
>> 	2. call firmware init by smp_ops.
>>
>> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
>
> Yes, this all looks reasonable to me. One possible idea though:
Thanks, I'll split the patches into generic firmware patch and exynos
specific patch.
>
>> +
>> +int __init exynos_firmware_init(void)
>> +{
>> +	firmware_ops.do_idle = exynos_do_idle;
>> +	firmware_ops.cpu_boot = exynos_cpu_boot;
>> +	return 0;
>> +}
>
> Instead of initializing each field separately, how about copying
> the entire data structure and do
>
> static struct firmware_ops exynos_firmware_ops __initdata = {
> 	.do_idle = exynos_do_idle,
> 	.cpu_boot = exynos_cpu_boot,
> };
>
> void __init exynos_firmware_init(void)
> {
> 	firmware_ops = exynos_firmware_ops;
> }
No problem. I'll update it.

Thank you,
Kyungmin Park