[GIT PULL] SPEAr platform fixes over 3.5-rc7

Shiraz Hashim shiraz.hashim at st.com
Wed Jul 18 02:16:26 EDT 2012


Hi Olof,

On Tue, Jul 17, 2012 at 10:58:46PM -0700, Olof Johansson wrote:
> Thanks for the quick turnaround. I've pulled this branch into fixes
> and will send it up to Linus tonight or tomorrow morning once the at91
> branch has been sorted out too.

OK. Thanks.

> One remaining nit: Your signed-off-by lines should be the very last
> line, since you were the last person to touch the patch. You would
> normally add Acked-by lines that came in above your own S-o-b, not
> below. Please keep that in mind for future patches (if you use git am
> -s then git will handle this automatically).

Oh. Sorry for my ignorance, would take care in future.

One question though, what if I already have commits in my repo and I
am not applying them from email. How to quickly add signed-off-by
lines to existing commits in a branch.

--
regards
Shiraz



More information about the linux-arm-kernel mailing list