[PULL] [PATCH 0/4] arm: at91: gpio fix

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Jul 18 01:23:44 EDT 2012

On 20:54 Tue 17 Jul     , Olof Johansson wrote:
> Hi Jean-Christophe,
> Comments below. As I mentioned in the SPEAr pull request just now, we
> are very close to final 3.5, so only fixes to bugs should go in.
> Please help me out a bit below.
> On Sun, Jul 15, 2012 at 6:16 AM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj at jcrosoft.com> wrote:
> > Jean-Christophe PLAGNIOL-VILLARD (4):
> >       ARM: at91: gpio: implement request
> >       ARM: at91: gpio: implement gpio_free
> Are the two above regressions, or just general improvement? Looks like
> the latter to me?
On non dt I agree but on DT the gpio are not mux in the kernel.
Today it work if the bootloader mux it as gpio so the kernel work onther wise BUG

and this is the case today
> >       at91: regroup gpio and pinctrl under a simple-bus
> This looks like a cleanup patch to me. I'm also not sure that this is
> appropriate use of a simple-bus. The patch seems to have been posted
> for review the same day as you sent the pull request, and not cc:d to
> devicetree-discuss.
forget to cc the devicetree but on at91 the pintcrl and gpio use the same
registers so you must you the simple-bus

As I've a huge patch series that I'm finishing to fix after found this bug on
the gpio it really help to do not rebase it

Best Regards,

More information about the linux-arm-kernel mailing list