[PATCH 12/12] USB: chipidea: add imx usbmisc support

Marek Vasut marex at denx.de
Mon Jul 16 08:24:24 EDT 2012


Dear Richard Zhao,

[...]

> +static int imx6q_usbmisc_init(struct usbmisc *usbmisc, int id)
> +{
> +	u32 reg;
> +
> +	if (usbmisc->dis_oc) {
> +		reg = readl_relaxed(usbmisc->base + id * 4);
> +		writel_relaxed(reg | (1 << 7), usbmisc->base + id * 4);


1<< 7 ? This yearns for fixing with proper #defined value.

[...]

The rest of the patches looks OK, you can add my Reviewed-By: <marex at denx.de> to 
those. This one though will need further investigation.

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list