[PATCHv3] I2C: MV64XXX: Add Device Tree support
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Mon Jul 16 08:20:19 EDT 2012
Le Mon, 16 Jul 2012 11:16:45 +0200,
Andrew Lunn <andrew at lunn.ch> a écrit :
> + - reg : Offset and length of the register set for the device
> + - compatible : Should be "marvell,mv64xxx-i2c"
> + - interrupts : Te interrupt number
The
> + i2c at 11000 {
> + compatible = "marvell,mv64xxx-i2c";
> + reg = <0x11000 0x20>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <29>;
> + clock-frequency = <400000>;
> + timeout-ms = <1000>;
> + status = "disable";
This should be "disabled". Any other status than "okay" is considered
as disabled, if I'm correct, but the right opposite to "okay" is
"disabled", as far as I'm aware.
The #ifdef machinery in the ->probe() function looks a bit ugly, but I
guess this can be cleaned up once all platforms using this driver will
have been converted to DT + clock framework.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the linux-arm-kernel
mailing list