[PATCH v2 01/15] ARM: Add fixed PCI i/o mapping
robherring2 at gmail.com
Mon Jul 16 00:35:14 EDT 2012
On 07/14/2012 07:22 AM, Nicolas Pitre wrote:
> On Fri, 13 Jul 2012, Rob Herring wrote:
>> + vm->size = size;
>> + vm->flags = VM_IOREMAP | VM_ARM_STATIC_MAPPING;
>> + vm->caller = vm_reserve_area_early;
> This is not providing much useful information when looking at
> /proc/vmallocinfo anymore. What about adding a void *caller argument to
> this function and initializing vm->caller with it to identify the true
> origin of the region?
What about just using __builtin_return_address(0)? Since pci_reserve_io
and devicemaps_init get inlined, ultimately it shows paging_init doing that.
>> + vm_area_add_early(vm
> Why ++ ?
Just a cut and paste left over.
> Other than that...
> Acked-by: Nicolas Pitre <nico at linaro.org>
More information about the linux-arm-kernel