[PATCH v5 6/6] spi: s3c64xx: add device tree support

Kukjin Kim kgene.kim at samsung.com
Fri Jul 13 09:42:52 EDT 2012


Thomas Abraham wrote:
> 
> On 13 July 2012 16:58, Kukjin Kim <kgene.kim at samsung.com> wrote:
> > Thomas Abraham wrote:
> >>
> >> On 13 July 2012 04:08, Kukjin Kim <kgene.kim at samsung.com> wrote:
> >> > Thomas, the DMACH_DT_PROP is available only on pl330 now. So seems
> occur
> >> > following build error with s3c6400_defconfig.
> >> >
> >> > drivers/spi/spi-s3c64xx.c: In function 's3c64xx_spi_get_dmares':
> >> > drivers/spi/spi-s3c64xx.c:1098: error: 'DMACH_DT_PROP' undeclared
> (first
> >> use
> >> > in this function)
> >> > drivers/spi/spi-s3c64xx.c:1098: error: (Each undeclared identifier is
> >> > reported only once
> >> > drivers/spi/spi-s3c64xx.c:1098: error: for each function it appears
> in.)
> >> > make[3]: *** [drivers/spi/spi-s3c64xx.o] Error 1
> >> > make[2]: *** [drivers/spi] Error 2
> >> >
> >>
> >> Dear Mr. Kim,
> >>
> >> Thanks for considering these patches to be merged via your tree. For
> >> the build break you mentioned above, there was a patch submitted some
> >> time back to handle this. The link to that patch is:
> >> http://lists.infradead.org/pipermail/linux-arm-kernel/2012-
> >> June/102627.html.
> >> Could you please apply this patch also to your tree.
> >>
> > Sure, it looks good to me, will apply that then this series will be
> rebased
> > on top of that.
> 
> There are six more patches that enable spi device tree support for
> Exynos4 and Exynos5 platforms. Could you consider to apply those
> patches as well. The link to those patches is:
> http://www.mail-archive.com/linux-samsung-
> soc at vger.kernel.org/msg10851.html.
> 
Yeah, I remember, but I think some patches is needed to re-work as per
comments...?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list