[PATCH] ARM: Exynos: Add device tree node for Exynos4 interrupt combiner controller

[Thomas Abraham]

On 12 July 2012 14:40, Kukjin Kim <kgene.kim at samsung.com> wrote:
> Thomas Abraham wrote:
>>
>> Add node for Exynos4 interrupt combiner controller.
>>
>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
>> ---
>>  arch/arm/boot/dts/exynos4210.dtsi |   11 +++++++++++
>>  1 files changed, 11 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4210.dtsi
>> b/arch/arm/boot/dts/exynos4210.dtsi
>> index a1dd2ee..0e4f659 100644
>> --- a/arch/arm/boot/dts/exynos4210.dtsi
>> +++ b/arch/arm/boot/dts/exynos4210.dtsi
>> @@ -33,6 +33,17 @@
>>               reg = <0x10490000 0x1000>, <0x10480000 0x100>;
>>       };
>>
>> +     combiner:interrupt-controller at 10440000 {
>> +             compatible = "samsung,exynos4210-combiner";
>> +             interrupt-controller;
>> +             #interrupt-cells = <2>;
>
> How about changing above ordering like interrupt gic controller?

Ok.

>
> +               #interrupt-cells = <2>;
> +               interrupt-controller;
>
> And, don't we need combiner-nr?
> +               samsung,combiner-nr = <16>;

'samsung,combiner-nr' is an optional property. If it is not specfied,
the default value is set as 16. So it is not required for Exynos4
combiner node.

I will resubmit this patch with your suggested change.

Thanks,
Thomas.