[PATCH v3 1/2] pinctrl: pinctrl-imx: add support for set bits for general purpose registers

Dong Aisheng dongas86 at gmail.com
Thu Jul 12 12:12:27 EDT 2012


On Thu, Jul 12, 2012 at 8:16 PM, Richard Zhao <linuxzsc at gmail.com> wrote:
[...]
>> +int imx_pinctrl_gpr_write(u8 gpr, u32 mask, u32 val)
>> +{
>> +     u32 reg;
>> +
>> +     if (!imx_pinctrl)
>> +             return -EPROBE_DEFER;
>> +
>> +     spin_lock(&imx_pinctrl->gprlock);
> spin_lock_irqsave? We don't know whether people call it in isr.
>
Yes, we definitely should support call it in isr.
thanks for pointing out this.
Will fix it in next version.

Regards
Dong Aisheng



More information about the linux-arm-kernel mailing list