[RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

Shawn Guo shawn.guo at linaro.org
Wed Jul 11 21:10:40 EDT 2012


On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote:
> This was introduced in commit
> 
> 	876989d (mfd: Add device tree probe support for mc13xxx)
> 
> for spi and later while introducing support for i2c copied to the i2c
> driver.
> 
> Modifying driver details is very strange, for example probing an
> mc13892 device (instantiated via dt) removes the driver's ability to
> handle (traditionally probed) mc13783 devices in this case.
> I'm not aware of any problems that make this hack necessary and if
> there were some, they'd have to be fixed in the spi/i2c core, not in
> a driver.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

The code was added by me, and it turns out the change is completely
unnecessary.  So,

Acked-by: Shawn Guo <shawn.guo at linaro.org>

Regards,
Shawn




More information about the linux-arm-kernel mailing list