[PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

DebBarma, Tarun Kanti tarun.kanti at ti.com
Wed Jul 11 13:56:31 EDT 2012


On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley <paul at pwsan.com> wrote:
> On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote:
>
>> Since the bank->dbck initialization in a one time operation there
>> is no need to keep this within gpio_debounce(). Therefore, moving
>> clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of
>> bank->dbck would be NULL at the beginning, this check has been
>> removed.
>>
>> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti at ti.com>
>> Reported-by: Paul Walmsley <paul at pwsan.com>
>> Reviewed-by: Jon Hunter <jon-hunter at ti.com>
>> Cc: Kevin Hilman <khilman at ti.com>
>> Cc: Rajendra Nayak <rnayak at ti.com>
>> Cc: Santosh Shilimkar <santosh.shilimkar at ti.com>
>> Cc: Cousson, Benoit <b-cousson at ti.com>
>> Cc: Paul Walmsley <paul at pwsan.com>
>> ---
>>  drivers/gpio/gpio-omap.c |   10 ++++------
>>  1 files changed, 4 insertions(+), 6 deletions(-)
>
> Reviewed-by: Paul Walmsley <paul at pwsan.com>
>
> These drivers are maintained by Grant Likely and Linus Walleij:
>
> GPIO SUBSYSTEM
> M:      Grant Likely <grant.likely at secretlab.ca>
> M:      Linus Walleij <linus.walleij at stericsson.com>
> S:      Maintained
> T:      git git://git.secretlab.ca/git/linux-2.6.git
> F:      Documentation/gpio.txt
> F:      drivers/gpio/
> F:      include/linux/gpio*
>
> So you'll want to cc them.  They are probably also who should merge these.
Ok, I wanted Kevin to have a look first. Anyways, I have cc'ed.
Thanks.
--
Tarun
>
>
> - Paul



More information about the linux-arm-kernel mailing list