[PATCH v2] rtc: snvs: add Freescale rtc-snvs driver

Shawn Guo shawn.guo at linaro.org
Tue Jul 10 22:57:55 EDT 2012


On Tue, Jul 10, 2012 at 07:02:21PM -0500, Kim Phillips wrote:
> how, without the "simple-bus" addition to the sec_mon compatibles
> list in the imx6 device tree (which isn't present in this patch)?
> 
This patch does not present anything about sec_mon node.  It's all
about sec_mon_rtc_lp node.  The driver itself does not know if the
rtc_lp node is a subnode of sec_mon node at all.

Can you please tell me what exact change you expect me to make on
drivers/rtc/rtc-snvs.c?  The patch merely adds a lp-rtc driver and
should not include any platform specific changes (dts, etc.)  The
driver and dts changes are two orthogonal parts, and should go via
RTC tree and ARCH tree separately.

> interesting.  When I add
> 
> +#define readl in_be32
> +#define writel(val, addr)             out_be32(addr, val)
> 
> to the top of the driver, the soft-lockup moves to
> rtc_read_lp_counter().  I'm trying to verify if I have the right h/w
> revision.
> 
You can submit an incremental patch later to make the driver work for
powerpc.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list