[PATCH v2 3/7] ARM: mxs: convert m28evk board to device tree

Marek Vasut marex at denx.de
Tue Jul 10 11:37:15 EDT 2012


Dear Shawn Guo,

> On Tue, Jul 10, 2012 at 09:20:03AM +0200, Marek Vasut wrote:
> > Dear Shawn Guo,
> > 
> > > From: Marek Vasut <marex at denx.de>
> > 
> > [...]
> > 
> > > +	sound {
> > > +		compatible = "fsl,imx28-evk-sgtl5000",
> > 
> > imx28-evk ? ;-)

Good on my end.

> Fixed as below.
> 
> Regards,
> Shawn

[...]

> diff --git a/arch/arm/boot/dts/m28evk.dts b/arch/arm/boot/dts/m28evk.dts

Just a suggestion -- why not name all the imx28-based boards' DTS files "imx28-
<board>.dts" ? In this case imx28-m28evk.dts , it'd make it obvious where this 
board fits.

[...]

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list