[PATCH v1 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

Venu Byravarasu vbyravarasu at nvidia.com
Tue Jul 10 02:03:23 EDT 2012


> > +
> > +#ifdef CONFIG_PM

Should it not be CONFIG_PM_SLEEP instead of just CONFIG_PM? 

> > +
> > +static int omap_usb2_runtime_suspend(struct device *dev)
> > +{
> > +	struct platform_device	*pdev = to_platform_device(dev);
> > +	struct omap_usb	*phy = platform_get_drvdata(pdev);
> > +


> > +static int __init usb2_omap_init(void)
> > +{
> > +	return platform_driver_register(&omap_usb2_driver);
> > +}
> > +arch_initcall(usb2_omap_init);
> > +
> > +static void __exit usb2_omap_exit(void)
> > +{
> > +	platform_driver_unregister(&omap_usb2_driver);
> > +}
> > +module_exit(usb2_omap_exit);
> > +

Do you really need arch_initcall here?
If not, then you can replace above two function calls with module_platform_driver().

> > +MODULE_ALIAS("platform: omap_usb2");
> > +MODULE_AUTHOR("Texas Instruments Inc.");
> > +MODULE_DESCRIPTION("OMAP USB2 PHY DRIVER");



More information about the linux-arm-kernel mailing list