[PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping

Lee Jones lee.jones at linaro.org
Mon Jul 9 16:34:37 EDT 2012


> Why do you keep these assignments and then override them with
> translations? Why don't you do
>
> 	ponkey->idev = input;
> 	ponkey->ab8500 = ab8500;
> 	ponkey->irq_dbf = ab8500_irq_get_virq(ab8500, irq_dbf);
> 	ponkey->irq_dbr = ab8500_irq_get_virq(ab8500, irq_dbr);
>
> to begin with?

Ah, I see what you mean now.

Sorry, just glossed over your first email.



More information about the linux-arm-kernel mailing list