[PATCH 00/15] PCI io.h cleanups

Arnd Bergmann arnd at arndb.de
Mon Jul 9 12:28:37 EDT 2012


On Friday 06 July 2012, Rob Herring wrote:
> From: Rob Herring <rob.herring at calxeda.com>
> 
> I've finally gotten back to this after several months. This is the 2nd
> part of mach/io.h removals. This series removes io.h on platforms with
> PCI by creating a fixed virtual I/O mapping and a common __io() macro.
> 
> As several platforms have 2 1MB I/O windows, I've changed the fixed
> mapping to 2MB (vs. 1MB in the prior posting) and allow platforms to
> control the size. This also allows using a single 1MB section mapping
> rather than 4KB pages.

Looks really good, feel free to add my Reviewed-by on patches 2-15, since
I've done a line-by-line walkthrough and could not find anything besides the
trivial comments I gave.

> I've only tested versatilepb under qemu, so any testing is appreciated.
> iop3xx and mv78xx0 have some risk of breaking as the PCI bus addresses
> are moved to 0 from matching the cpu host bus addesss.

Did you try running any devices that actually use I/O space in qemu?
I think there are plenty of devices that you could use for testing that.

	Arnd



More information about the linux-arm-kernel mailing list