[PATCH] [v3] i.MX27: Fix emma-prp clocks in mx2_camera.c

[javier Martin]

On 9 July 2012 09:43, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> On Mon, Jul 09, 2012 at 09:37:25AM +0200, javier Martin wrote:
>> On 9 July 2012 09:28, Sascha Hauer <s.hauer at pengutronix.de> wrote:
>> > On Fri, Jul 06, 2012 at 12:56:02PM +0200, Javier Martin wrote:
>> >> This driver wasn't converted to the new clock changes
>> >> (clk_prepare_enable/clk_disable_unprepare). Also naming
>> >> of emma-prp related clocks for the i.MX27 was not correct.
>> >> ---
>> >> Enable clocks only for i.MX27.
>> >>
>> >
>> > Indeed,
>> >
>> >>
>> >> -     pcdev->clk_csi = clk_get(&pdev->dev, NULL);
>> >> -     if (IS_ERR(pcdev->clk_csi)) {
>> >> -             dev_err(&pdev->dev, "Could not get csi clock\n");
>> >> -             err = PTR_ERR(pcdev->clk_csi);
>> >> -             goto exit_kfree;
>> >> +     if (cpu_is_mx27()) {
>> >> +             pcdev->clk_csi = devm_clk_get(&pdev->dev, "ahb");
>> >> +             if (IS_ERR(pcdev->clk_csi)) {
>> >> +                     dev_err(&pdev->dev, "Could not get csi clock\n");
>> >> +                     err = PTR_ERR(pcdev->clk_csi);
>> >> +                     goto exit_kfree;
>> >> +             }
>> >
>> > but why? Now the i.MX25 won't get a clock anymore.
>>
>> What are the clocks needed by i.MX25? csi only?
>>
>> By the way, is anybody using this driver with i.MX25?
>
> It seems Baruch (added to Cc) has used it on an i.MX25.

Baruch,
could you tell us what are the clocks needed by i.MX25?

Regards.
-- 
Javier Martin
Vista Silicon S.L.
CDTUC - FASE C - Oficina S-345
Avda de los Castros s/n
39005- Santander. Cantabria. Spain
+34 942 25 32 60
www.vista-silicon.com