[PATCH v2 1/4] usb: chipidea: pci: make platformdata static

[Richard Zhao]

On Sun, Jul 08, 2012 at 06:48:49PM +0100, Russell King - ARM Linux wrote:
> On Sun, Jul 08, 2012 at 11:10:04PM +0800, Richard Zhao wrote:
> > On Thu, Jun 28, 2012 at 10:06 PM, Richard Zhao <linuxzsc at gmail.com> wrote:
> > > On Thu, Jun 28, 2012 at 03:53:46PM +0200, Marc Kleine-Budde wrote:
> > >> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> > >> ---
> > >>  drivers/usb/chipidea/ci13xxx_pci.c |    6 +++---
> > >>  1 file changed, 3 insertions(+), 3 deletions(-)
> > >>
> > >> diff --git a/drivers/usb/chipidea/ci13xxx_pci.c b/drivers/usb/chipidea/ci13xxx_pci.c
> > >> index 918e149..9f5c171 100644
> > >> --- a/drivers/usb/chipidea/ci13xxx_pci.c
> > >> +++ b/drivers/usb/chipidea/ci13xxx_pci.c
> > >> @@ -23,17 +23,17 @@
> > >>  /******************************************************************************
> > >>   * PCI block
> > >>   *****************************************************************************/
> > >> -struct ci13xxx_platform_data pci_platdata = {
> > >> +static struct ci13xxx_platform_data pci_platdata = {
> > > what about adding __devinitdata?
> > Marc, what do you think?
> 
> Not on statically declared platform data.  That's always a mistake.
> 
Could you please explain more?
platdata in this driver is duplicated when call ci13xxx_add_device in
probe.

Thanks
Richard