[PATCH] ARM: PRIMA2: convert to common clk and finish full clk tree

Barry Song 21cnbao at gmail.com
Sun Jul 8 03:26:01 EDT 2012


Hi Mike,

2012/7/7 Arnd Bergmann <arnd at arndb.de>:
> On Saturday 07 July 2012, Mike Turquette wrote:
>> I don't mind dropping your patches from clk-next and taking new ones.
>> Go ahead and send me a new patch which does everything instead of an
>> incremental patch to simply 'git mv' the code.  Feel free to split the
>> patch up if needed.
>
> FWIW, I would always recommend doing this in two patches, one that changes
> the code and one that moves the file, in either order. The main difference
> is that for those who cannot use 'git diff -M', reviewing the patch becomes
> much easier when it doesn't look like one file is removed and another
> completely different file is added.

i tend towards the latter one. i am thinking those might be two jobs:
1. change the current drivers to common clk and finish the whole tree
2. move the updated driver to the right place after 1

so they might be two patches, how do you think?

>
>         Arnd

-barry



More information about the linux-arm-kernel mailing list