[PATCH v2 0/4] ARM: OMAP2+: dmtimer: cleanup related to devm API and clk usage

DebBarma, Tarun Kanti tarun.kanti at ti.com
Thu Jul 5 07:41:27 EDT 2012


Hi Tony,

On Thu, Jul 5, 2012 at 2:58 PM, Tony Lindgren <tony at atomide.com> wrote:
> * DebBarma, Tarun Kanti <tarun.kanti at ti.com> [120704 21:07]:
>> On Thu, Jun 14, 2012 at 4:28 PM, Shilimkar, Santosh <santosh.shilimkar at ti.com> wrote:
>> >
>> > Just to let you know that this cleanup is essential for Benoit's OMAP4
>> > hwmod cleanup
>> > and OMAP5 minimal support series.
>>
>> This is a gentle reminder in case you have missed somehow!!
>> Let me know if anything else needs to be done.
>
> Now with the hwmod patch 2/4 pulled into cleanup-part2 from Paul,
> I've also applied patch 1/4 there. Patches 3 and 4 have still some pending
> comments from Kevin it seems?
Yes....

>
> Also at least patch 3 won't apply, so please check Kevin's comments
> and repost patches 3 and 4 on top of cleanup-part2 at commit 74dd9ec62.
Patch 3: Comment was about adding summary in patch 0/x why we have
not removed iclk in OMAP2/3 platform. In other words there was no
specific changes needed on patch 3 as such. BTW, patch 3 is already merged.

Patch 4:
--- [Kevin's comment] ---
>>
>> Comment applies to PATCH 4/4 also.
> You mean removing iclk from clkdev table? That is already done in this patch!!
I meant why can't OMAP2/3 data be removed in PATCH 4/4 also, which only
touches OMAP4.
--- [end] -----------------------
In patch 4 the only change done in the clock table was to correct the
name mis-match
of functional clock names for OMAP4 between clock data and hwmod data.
For OMAP2/3 the names are already matching. As the comment was given in patch 3
where iclk entries got removed for OMAP4, he must have expected similar cleanup
is done for fclk in patch 4. But as I said, only the name mis-match is
corrected.
In summary, there is no specific changes needed in the patch.

I will rebase on top of cleanup-part2 are repost patch 4.
--
Tarun
>
> Regards,
>
> Tony



More information about the linux-arm-kernel mailing list