[PATCH 8/8] mmc: spi: Add DMA support into SPI driver

Marek Vasut marex at denx.de
Wed Jul 4 19:20:07 EDT 2012


Dear Marek Vasut,

> Dear Fabio Estevam,
> 
> > Hi Marek,
> > 
> > On 6/29/12, Marek Vasut <marex at denx.de> wrote:
> > >  	iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > 
> > > -	if (!iores)
> > > +	dmares = platform_get_resource(pdev, IORESOURCE_DMA, 0);
> > > +	irq_err = platform_get_irq(pdev, 0);
> > > +	irq_dma = platform_get_irq(pdev, 1);
> > > +	if (!iores || irq_err < 0 || irq_dma < 0)
> > 
> > Shouldn't you check for dmares < 0 here too?
> 
> Yes. What about the rest of the patches? Are they applicable?

(Lemme answer to myself)

The DT documentation is missing. Ok, I'll send it in the next round. So any 
other comments please? :)

> Best regards,
> Marek Vasut

Best regards,
Marek Vasut



More information about the linux-arm-kernel mailing list