[PATCHv2 0/6] ARM: jump label support

Jon Medhurst (Tixy) tixy at linaro.org
Tue Jan 31 03:23:14 EST 2012


On Sat, 2012-01-28 at 19:05 +0530, Rabin Vincent wrote:
> v2:
>  - Use helper macros from Dave Martin's "ARM: Add generic instruction opcode
>    manipulation helpers"
>    http://www.arm.linux.org.uk/developer/patches/viewpatch.php?id=7278/1

This patch is broken, it contains two diff listings for
arch/arm/include/asm/opcodes.h

The second one looks more correct as the diff accounts for commit
0c9030deaf59d444 (ARM: 7206/1: Add generic ARM instruction set condition
code checks). However, when opcodes.h is included in assembler files it
produces error as it #includes C headers.

Moving the #ifndef __ASSEMBLY__ to above the #includes makes things
compile cleanly...

+#ifndef __ASSEMBLY__
 #include <linux/types.h>
 #include <linux/swab.h>

-#ifndef __ASSEMBLY__


-- 
Tixy




More information about the linux-arm-kernel mailing list