[PATCH] ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision

[Hiremath, Vaibhav]

On Fri, Jan 27, 2012 at 05:55:43, Tony Lindgren wrote:
> * Vaibhav Hiremath <hvaibhav at ti.com> [120122 23:26]:
> > Add missing break statement in the function omap3xxx_check_revision.
> > 
> > The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros
> > and detection support], removed the 'break' statement from the function
> > omap3xxx_check_revision(), resulting into wrong omap/cpu_revision
> > initialization for AM335x devices.
> 
> Looks like this is already fixed, can you please verify with
> v3.3-rc1?
> 
Tony,

I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required.

I can still see,

394                 }
395                 break;
396         case 0xb944:
397                 omap_revision = AM335X_REV_ES1_0;
398                 cpu_rev = "1.0";
399         case 0xb8f2:
400                 switch (rev) {


Thanks,
Vaibhav


> Regards,
> 
> Tony
>  
> > Signed-off-by: Vaibhav Hiremath <hvaibhav at ti.com>
> > Cc: Tony Lindgren <tony at atomide.com>
> > ---
> >  arch/arm/mach-omap2/id.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 325e12e..32cf203 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
> >  	case 0xb944:
> >  		omap_revision = AM335X_REV_ES1_0;
> >  		cpu_rev = "1.0";
> > +		break;
> >  	case 0xb8f2:
> >  		switch (rev) {
> >  		case 0:
> > --
> > 1.7.0.4
> > 
>