[PATCH] ARM: mxs: read correct values when setting up MAC

[Wolfram Sang]

> > --- a/arch/arm/mach-mxs/mach-m28evk.c
> > +++ b/arch/arm/mach-mxs/mach-m28evk.c
> > @@ -258,7 +258,7 @@ static int __init m28evk_fec_get_mac(void)
> >  	 * so hard-code DENX OUI (C0:E5:4E) here.
> >  	 */
> >  	for (i = 0; i < 2; i++) {
> > -		val = ocotp[i * 4];
> > +		val = ocotp[i];
> 
> I can read that HW_OCOTP_CUST0 has the phisycal address 0x8002_C020h,
> and HW_OCOTP_CUST1 ist at 8002_C030h. So the two registers are not
> consecutive and there are some reserved fields between the two registers
> - this is the reason for the i * 4.
> 
> HW_OCOTP_CRYPTO0 is at 8002_C060h, so it is not true that the address is
> currently read from the crypto-key. At least, this is my interpretation...

Ah, that explains... that you probably never tested the code? What about
this in ocotp.c?

 75         for (i = 0; i < OCOTP_WORD_COUNT; i++)
 76                 ocotp_words[i] = __raw_readl(ocotp_base + OCOTP_WORD_OFFSET +
 77                                                 i * 0x10);

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120125/63b98517/attachment.sig>