[PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer

Kevin Hilman khilman at ti.com
Tue Jan 24 12:47:56 EST 2012


"Hiremath, Vaibhav" <hvaibhav at ti.com> writes:

> On Tue, Jan 24, 2012 at 05:08:50, Hilman, Kevin wrote:
>> Vaibhav Hiremath <hvaibhav at ti.com> writes:
>> 
>> > OMAP device has 32k-sync timer which is currently used as a
>> > clocksource in the kernel (omap2plus_defconfig).
>> > The current implementation uses compile time selection between
>> > gp-timer and 32k-sync timer, which breaks multi-omap build for
>> > the devices like AM33xx, where 32k-sync timer is not available.
>> >
>> > So use hwmod database lookup mechanism, through which at run-time
>> > we can identify availability of 32k-sync timer on the device,
>> > else fall back to gp-timer.
>> 
>> With the runtime detection & fallback, I suggest also removing the
>> Kconfig choice between the two as well.
>> 
> Kevin,
>
> Actually I thought of cleaning whole 32KTIMER related code,
> but then realized that, it would be major cleanup, since
> it is being used in lot of places.
>
> So let's not block this patch-series for this further cleanup.
> I will work on cleaning up the complete 32KTIMER macro and 
> submit the patches.

OK, Tony can make the call.

Kevin



More information about the linux-arm-kernel mailing list