[PATCH v2 14/15] ARM: local timers: convert MSM to runtime registration interface

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jan 13 17:47:09 EST 2012


On Fri, Jan 13, 2012 at 02:37:40PM -0800, David Brown wrote:
> On Fri, Jan 13, 2012 at 06:28:41PM +0000, Marc Zyngier wrote:
> > Convert the MSM timers to the runtime registration interface.
> > 
> > Cc: Stephen Boyd <sboyd at codeaurora.org>
> > Tested-by: David Brown <davidb at codeaurora.org>
> > Acked-by: David Brown <davidb at codeaurora.org>
> > Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>
> 
> Ok, this is definitely now consistenly causing cpu hotplug to fail.
> I'll look in to this further, but for now, please removed my Tested-by
> and Acked-by.

That'll be because the local_timer_ops structure is marked __initdata
but is used after init has completed.  It should be marked __cpuinitdata
if it's used for CPU bringup (which it is.)



More information about the linux-arm-kernel mailing list