[RFC PATCH 04/10] ARM: it8152: explicitly include mach/irqs.h

[Nicolas Pitre]

On Fri, 13 Jan 2012, Rob Herring wrote:

> On 01/13/2012 10:34 AM, Rob Herring wrote:
> > From: Rob Herring <rob.herring at calxeda.com>
> > 
> > In preparation to make mach/irqs.h optional, directly include mach/irq.h
> > to get IRQ_BOARD_START.
> > 
> > Signed-off-by: Rob Herring <rob.herring at calxeda.com>
> > ---
> >  arch/arm/include/asm/hardware/it8152.h |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/include/asm/hardware/it8152.h b/arch/arm/include/asm/hardware/it8152.h
> > index 43cab49..73f84fa 100644
> > --- a/arch/arm/include/asm/hardware/it8152.h
> > +++ b/arch/arm/include/asm/hardware/it8152.h
> > @@ -9,6 +9,9 @@
> >  
> >  #ifndef __ASM_HARDWARE_IT8152_H
> >  #define __ASM_HARDWARE_IT8152_H
> > +
> > +#include <mach/irqs.h>
> > +
> 
> This include is needed for IRQ_BOARD_START which could also be
> problematic outside a single mach dir. The IT8152 is only used on 1
> family of pxa2xx boards. The part and board with it are EOL as well, so
> we're not going to see new users of this code. Perhaps the it8152 code
> should just be moved into mach-pxa?

No no.  Any reason will be good to do the same for other stuff and we 
really don't want to go back there.  If anything it is the needed 
defines that need to move closer to the driver code not the other way 
around.

And by the time the EOL'd boards are really getting into the way of 
cleanups we could do one of two things: simply leave them alone and 
prevent them from participating into a multi-SOC kernel config. Or add a 
#error "Do you care about me?" in them (and remove them from any 
defconfig) and see if anyone notices.  If not then we just delete them.


Nicolas