[PATCH 1/2] mach-ux500: cache operations are atomic on PL310

Will Deacon will.deacon at arm.com
Fri Jan 13 13:14:22 EST 2012


Hi guys,

On Thu, Jan 12, 2012 at 05:37:42AM +0000, Srinidhi KASAGAR wrote:
> Apply ERRATA_753970 for ux500 variant of cache sync too
> 
> Signed-off-by: srinidhi kasagar <srinidhi.kasagar at stericsson.com>
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>  arch/arm/mach-ux500/cache-l2x0.c |   11 ++++++++---
>  1 files changed, 8 insertions(+), 3 deletions(-)

I hadn't noticed the existence of this file before, but this patch really
shows why it's not a good idea to copy files out of core ARM code and into
the mach-* directories. I see that the commit introducing this file 458eef2f
("mach-ux500: factor out l2x0 handling code") mentions that mach-imx does
the same thing, but I can't find the code there.

On top of that, it seems as though you provide an inv_all implementation
but your disable function is empty. Surely this can lead to data loss?

Will



More information about the linux-arm-kernel mailing list