[PATCH] arm: omap4: Fix omap_barriers_init for generic ioremap changes

Shilimkar, Santosh santosh.shilimkar at ti.com
Fri Jan 13 05:35:13 EST 2012


On Thu, Jan 12, 2012 at 10:00 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Thu, Jan 12, 2012 at 09:32:40PM +0100, Shilimkar, Santosh wrote:
>> OK. Point taken.
>
> Can you also explain this in the code:
>
>        size = ALIGN(PAGE_SIZE, SZ_1M);
>
> Isn't that just SZ_1M written in a rather complex way?  A comment may be
> a better way of explaining it.

memblock alloc was failing without the alignment IIRC. Will add comments
about the same.

Regards
Santosh



More information about the linux-arm-kernel mailing list