[PATCH 1/2] at91 : move pm.h header to arch/arm/include/asm

[Jean-Christophe PLAGNIOL-VILLARD]

On 14:44 Mon 09 Jan     , Russell King - ARM Linux wrote:
> On Mon, Jan 09, 2012 at 02:54:32PM +0100, Daniel Lezcano wrote:
> > On 01/09/2012 12:29 PM, Russell King - ARM Linux wrote:
> > > On Mon, Jan 09, 2012 at 12:19:17PM +0100, Daniel Lezcano wrote:
> > >> Actually, the header moves from :
> > >>
> > >> 	arch/arm/mach-at91/pm.h
> > >> to:
> > >> 	arch/arm/include/asm/at91_pm.h.
> > >>
> > >> This place and the renaming of the file complies with the comments of
> > >> Russell,
> > > 
> > > No it doesn't.  There's absolutely no way in hell I want arch/arm/include/asm
> > > to be littered with hundreds of crappy platform specific header files.
> > 
> > Ok. Actually there are 9 pm.h files but I agree with a domino effect we
> > can have more header files brought to this directory like "control.h",
> > "powerdomain.h", etc ...
> > 
> > Does it make sense to merge all the pm.h file in a single pm.h which
> > will be located in arch/arm/include/asm ?
> 
> No it doesn't.  If moving something out of arch/arm means that we have to
> buggerize the header files, then moving it out of arch/arm is the wrong
> thing to do.  What the need to bugger about with header files is telling
> you is that the code you're moving (in its existing form) is intimitely
> tied to the SoC.
> 
> There's two solutions to that: either leave it where it is, or first
> sort out why it's intimitely tied, and what can be done to remove its
> dependence on the SoC.
> 
> I've finally taken a deeper look at what's going on here... 
> 
> arch/arm/mach-at91/pm.h is full of crap:
I work on it but work on other clean up first

Best Regards,
J.