[PATCH v2] arm/tegra: emc: device tree support

Stephen Warren swarren at nvidia.com
Thu Jan 5 17:35:55 EST 2012


Olof Johansson wrote at Wednesday, January 04, 2012 11:02 PM:
> Add device tree support to the emc driver, filling in the platform data
> based on the DT bindings.
> 
> Changes since v1:
> 
> * Unmangled some messed up patch squashes, moving changes to earlier patches
> * Flipped an of_property_read_u32 return value test
> * Clarified clock settings message on case where no table is provided
> 
> Signed-off-by: Olof Johansson <olof at lixom.net>
...
> diff --git a/arch/arm/mach-tegra/tegra2_emc.c b/arch/arm/mach-tegra/tegra2_emc.c
...
> +static struct tegra_emc_pdata __devinit *tegra_emc_fill_pdata(struct platform_device *pdev)
...
> +	pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> +	pdata->tables = devm_kzalloc(&pdev->dev,
> +				     sizeof(struct tegra_emc_table),
> +				     GFP_KERNEL);

You could convert that one to sizeof(*pdata->tables) too, although feel
free to ignore this picky comment, or fix it up when you apply the change.

Otherwise,

Acked-by: Stephen Warren <swarren at nvidia.com>

-- 
nvpublic




More information about the linux-arm-kernel mailing list