[PATCH 2/2] arm/imx6q: add cko1 clock

[Shawn Guo]

On Thu, Jan 05, 2012 at 11:11:14AM +0800, Richard Zhao wrote:
> imx6q-sabrelite board use it as audio codec clock.
> 
> Signed-off-by: Richard Zhao <richard.zhao at linaro.org>
> ---
>  arch/arm/mach-imx/clock-imx6q.c |   74 ++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 73 insertions(+), 1 deletions(-)
> 
It mostly looks good.  A couple of comments below though:

* Again, use "ARM: imx6q: ..." for patch subject in this case.

* To reflect the CKO hardware hierarchy, we should probably have 3 clks
  there, cko_clk, cko1_clk and cko2_clk, and have cko_clk be the parent
  of the later two, as cko1_cko2_sel bit was designed for this.

[...]

> @@ -1680,7 +1734,7 @@ static int _clk_set_parent(struct clk *clk, struct clk *parent)
>  			break;
>  		i++;
>  	}
> -	if (!m->parents[i])
> +	if (!m->parents[i] || m->parents[i] == &dummy_clk)

Is this change necessarily included in this patch?

Regards,
Shawn

>  		return -EINVAL;
>  
>  	val = readl_relaxed(m->reg);