[PATCH v2 00/15] Make SMP timers standalone

Marc Zyngier marc.zyngier at arm.com
Thu Jan 5 06:35:56 EST 2012


On 05/01/12 11:26, Russell King - ARM Linux wrote:
> On Thu, Jan 05, 2012 at 11:19:32AM +0000, Marc Zyngier wrote:
>> Global timer is still present, configured and enabled. The kernel just
>> happens to select TWD as a better timer. Should TWD be turned off,
>> gp_timer will be selected again.
> 
> And at that point, the core time keeping code will find a local timer
> clock event structure and expect it's broadcast method to be implemented
> and working, as I described in my initial reply.
> 
>> This is also what happens with the current implementation, and my
>> patches don't change that.
> 
> Yes they do, because they omit the broadcast method.

I forgot to mention I restored this functionality after you pointed that
out (I made smp_timer_broadcast a global symbol).

> Look, local timers *are* special.  They're not the same as global timers.
> They're treated differently.  Ripping out the local timer setup stuff
> from the SMP code is not the right solution, especially when we've
> already got a separation of the local timer core from the hardware
> implementation.

OK. I'll try to work out something different.

	M.
-- 
Jazz is not dead. It just smells funny...




More information about the linux-arm-kernel mailing list