[PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

Bedia, Vaibhav vaibhav.bedia at ti.com
Tue Jan 3 05:24:40 EST 2012


Hi Govindraj,

On Mon, Jan 02, 2012 at 16:00:37, Govindraj wrote:
> 
> currently runtime pm is available from omap-serial device and not from tty_dev.
> Setting tty_dev wakeup is to use irq_wakeup from suspend available
> from serail_core layer which I think we are not using for omap-uart
> and we use pad wakeup from suspend path.
> 
> Also omap-uart.x/power/wakeup is used to gate uart clocks using runtime
> PM api's in omap-serial driver.
> 

Thanks for clarifying. On AM335x, one of the UARTs is in a wakeup domain
and swakeup from this is used to come out of suspend.

I have basic suspend-resume working on it. Strangely this works irrespective
of the value of tty_dev wakeup entry. Do you know if this is expected on OMAP?

The other issue concerning runtime PM is that as soon as I set a non-zero to
the autosuspend_delay_ms I get some garbage characters and eventually the
console stops responding.

[root at arago /]# cat .../omap_uart.0/power/autosuspend_delay_ms
-1
[root at arago /]# echo 3000 > ÖKWëé«+×é«+wU.Éѹ,z,½Ý.ɽosuspend_delayÕ£½ÍÕÍ...
[root at arago /]#	<- No response after some time

The comment in the code mentions delay is receiving characters if runtime PM
is enabled. Any idea what's going wrong at my end?

Regards,
Vaibhav B.



More information about the linux-arm-kernel mailing list