[PATCH v8 19/20] OMAP2+: UART: Do not gate uart clocks if used for debug_prints

Bedia, Vaibhav vaibhav.bedia at ti.com
Mon Jan 2 04:25:34 EST 2012


Hello,

On Fri, Nov 11, 2011 at 15:31:52, R, Govindraj wrote:
[...]
>  
> -	if ((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads)
> +	if (((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads)
> +			&& !uart_debug)
>  		device_init_wakeup(&pdev->dev, true);
>  }

I was testing this on AM335x and realized that this leads to creation of two
'wakeup' entries for UART. One is created by the tty layer in serial-core.c
and the other is created here.

Here's what I see on a branch based on Tony's 3.2-rc6:

./sys/devices/platform/omap/omap_uart.0/power/wakeup
./sys/devices/platform/omap/omap_uart.0/tty/ttyO0/power/wakeup

Shouldn't the OMAP serial just enable the 'wakeup' entry created by serial-core.c?

Regards,
Vaibhav



More information about the linux-arm-kernel mailing list