[PATCH 00/15] OMAP SHAM & AES Crypto Updates
Mark A. Greer
mgreer at animalcreek.com
Tue Dec 25 14:29:37 EST 2012
On Sun, Dec 23, 2012 at 08:40:43AM +0000, Paul Walmsley wrote:
> Hi Mark,
> On Fri, 21 Dec 2012, Mark A. Greer wrote:
> > From: "Mark A. Greer" <mgreer at animalcreek.com>
> > [This series supersedes the hwmod related patches sent in the
> > "crypto: omap-sham updates" and "crypto: omap-aes updates"
> > series a few weeks ago.]
> > This series adds hwmod support for the OMAP SHAM and AES
> > modules on OMAP2, OMAP3, and OMAP4/AM33XX SoCs. It also
> > adds device tree info for those modules.
> Thanks for working on this, this will get us much closer to being able to
> convert the hwmod code into an OMAP bus. I haven't looked closely at
> these patches yet, but a few comments/questions:
> - Looks like the two DTS patches are the ones with direct dependencies on
> the DMA Engine support patches that you mentioned.
The patch(es) that convert the drivers to use
dma_request_slave_channel_compat() will cause problems too if the
patch that adds that call isn't in your branch. AFAIK, this is the
latest version, https://patchwork.kernel.org/patch/1459231/ from
> Any objection to me
> taking the series without those two patches? Then once the DMA Engine
> series goes in, maybe those AM33xx DTS patches can go up?
No, no objections at all. I will track/resubmit/whatever the ones that
need to go in later.
> - The patch series causes AM3517/3505 to crash. I'd guess this is due to
> the SHAM/AES modules being initialized on those chips, but they probably
> don't exist there. Can you change the initialization for those on OMAP3
> to only take place on OMAP34xx/36xx GP? I guess you'd need to create new
> lists for those in the hwmod init.
Sure, I'll do what you suggest when I'm back to work in the new year.
More information about the linux-arm-kernel