[PATCH 2/3] ARM: pxa: palmtreo: fix #ifdefs for leds-gpio device
Marek Vasut
marex at denx.de
Sat Dec 22 22:20:55 EST 2012
Dear Mike Dunn,
> The #ifdefs around the leds-gpio device platform data are erroneous.
> Currently the device is not instantiated on the centro unless
> CONFIG_MACH_TREO680 is defined.
>
> Signed-off-by: Mike Dunn <mikedunn at newsguy.com>
> ---
>
> The #ifdefs within palmtreo_leds_init() are a little ugly, but I think the
> only alternative would be to instantiate the leds-gpio device platform
> data for both treo680 and centro, which would require some of the #defines
> in palmtreo.h to be moved outside their containing #ifdef
> CONFIG_MACH_{TREO680,CENTRO}.
Shall we not just kill all those ifdefs and let GCC decide what to optimize out?
I think this kind of simple stuff should just be optimized out anyway.
Best regards,
Marek Vasut
More information about the linux-arm-kernel
mailing list