[PATCH 4/4] devicetree: Add Renesas SH Mobile MSIOF spi controller binding doc

[Bastian Hecht]

Hello Grant,

>>> +Renesas MSIOF spi controller
>>> +
>>> +Required properties:
>>> +- compatible :       "renesas,sh-msiof" for SuperH or
>>> +             "renesas,sh-mobile-msiof" for SH Mobile series
>>> +- reg : Offset and length of the register set for the device
>>> +- interrupts : interrupt line used by MSIOF
>>> +
>>> +Optional properties:
>>> +- chip_select  : Chip select, defaults to 0
>>
>> This doesn't make a lot of sense to me. What is this property for? Is
>> there more than one CS? And if there is, shouldn't the SPI driver be
>> able to manipulate more than one?
>
> Oh, wait, from reading the code, is this the number of chip select
> lines? If so, then there is a common property for this. This property
> should be named "num-cs".

Yes, this value is nowhere used in the driver but just forwarded to
the SPI subsystem as the number of chip selects.

>>
>>> +- tx_fifo_size : Overrides the default tx fifo size given in words
>>> +- rx_fifo_size : Overrides the default rx fifo size given in words
>>
>> Nit: property names should use '-' instead of '_' (by convention) and
>> custom properties should be prefixed with the manufacturer prefix to
>> avoid namespace collisions. ie. "renesas,tx-fifo-size.

Ok sure! Thanks for pointing it out.

I'll post v2 in a second.

Thanks,

 Bastian

>> g.
>
>
>
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.