[PATCH 1/2] pinctrl: add sleep mode management for hogs
swarren at wwwdotorg.org
Tue Dec 11 16:11:48 EST 2012
On 12/11/2012 06:59 AM, Linus Walleij wrote:
> From: Julien Delacou <julien.delacou at stericsson.com>
> This fix allows handling sleep mode for hogged
> pins in pinctrl. It provides functions to set pins
> to sleep/default configurations according to their
> current state from the individual pinctrl drivers.
> diff --git a/include/linux/pinctrl/pinctrl.h b/include/linux/pinctrl/pinctrl.h
> +extern int pinctrl_force_sleep(struct pinctrl_dev *pctldev);
> +extern int pinctrl_force_default(struct pinctrl_dev *pctldev);
Since I assume those function are only supposed to be used by pinctrl
drivers themselves, should the prototypes go into drivers/pinctrl/core.h
or similar, rather than something in include/linux/pinctrl?
Oh, and don't you need EXPORT_SYMBOL in case the pinctrl driver is a module?
Aside from that,
Reviewed-by: Stephen Warren <swarren at nvidia.com>
More information about the linux-arm-kernel