[PATCH] ARM: decompressor: include CONFIG_DEBUG_LL_INCLUDE rather than mach/debug-macro.S

Russell King - ARM Linux linux at arm.linux.org.uk
Mon Dec 10 09:02:50 EST 2012


On Mon, Dec 10, 2012 at 09:59:18AM +0800, Shawn Guo wrote:
> On Mon, Dec 10, 2012 at 09:49:28AM +0800, Shawn Guo wrote:
> > Commit 91a9fec (ARM: move debug macros to common location) moves
> > arch/arm/kernel/debug.S and arch/arm/kernel/head.S to
> > CONFIG_DEBUG_LL_INCLUDE, but leaves arch/arm/boot/compressed/head.S
> > still with mach/debug-macro.S.  This causes the following build error
> > on platforms that moved to new DEBUG_LL inclusion mechanism, when
> > arch/arm/boot/compressed/head.S is compiled with DEBUG turned on.
> > 
> >   AS      arch/arm/boot/compressed/head.o
> > arch/arm/boot/compressed/head.S:49:30: fatal error: mach/debug-macro.S: No such file or directory
> > compilation terminated.
> > 
> > Fix the problem by replacing mach/debug-macro.S inclusion with
> > CONFIG_DEBUG_LL_INCLUDE one.
> > 
> > Reported-by: Steev Klimaszewski <steev at genesi-usa.com>
> > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> > Cc: stable at vger.kernel.org
> 
> I copied stable with assuming that the patch is not going to catch
> on the final 3.7 release.  If it's not the case or maintainer does not
> think it's a stable material at all, we can just drop the tag.

That worries me a bit because I can see this ending up getting applied to
multiple stable kernel trees, even those without CONFIG_DEBUG_LL_INCLUDE.
So, let's have it in the patch system without the stable tag.

Thanks.



More information about the linux-arm-kernel mailing list