[PATCH 1/2] thermal: Add support for thermal sensor for Kirkwood SoC
Thomas Petazzoni
thomas.petazzoni at free-electrons.com
Fri Dec 7 19:07:08 EST 2012
Hello,
On Sat, 8 Dec 2012 08:15:50 +0900, Nobuhiro Iwamatsu wrote:
> +config KIRKWOOD_THERMAL
> + tristate "Temperature sensor on Marvel Kirkwood"
Marvell
> + /* Valid check */
> + if (!(reg >> THERMAL_VALID_OFFSET) & THERMAL_VALID_MASK) {
> + dev_info(&thermal->device, "Reading temperature is not valid\n");
"Temperature read is not valid" maybe? An native english speaker could
say.
> + thermal_dev
> + = devm_kzalloc(&pdev->dev, sizeof(*thermal_dev), GFP_KERNEL);
I think the usual coding style is to have the = on the first line.
> +static int kirkwood_thermal_exit(struct platform_device *pdev)
> +{
> + struct thermal_zone_device *kirkwood_thermal
> + = platform_get_drvdata(pdev);
Ditto.
> +static const struct of_device_id kirkwood_thermal_id_table[] = {
> + { .compatible = "marvel,thermal-kirkwood" },
marvel -> marvell
Also, I think it should be marvell,kirkwood-thermal, since most other
DT compatible strings that we have for Marvell SoCs are
marvell,<soc>-<function>.
Also, the Device Tree binding documentation is missing (even though it
is admittedly going to be a very short documentation).
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
More information about the linux-arm-kernel
mailing list