[PATCH] ARM: Add .smp entry for REALVIEW_EB

Will Deacon will.deacon at arm.com
Wed Dec 5 13:18:36 EST 2012


Hi Steve,

On Tue, Dec 04, 2012 at 03:18:13PM +0000, Steve Capper wrote:
> The REALVIEW EB board can host tiles with multiple cores thus needs to be able
> to initialise SMP. There is, however, no .smp entry in the MACHINE_START
> struct for REALVIEW_EB.
> 
> This patch adds the appropriate .smp entry to this struct.
> 
> Signed-off-by: Steve Capper <steve.capper at arm.com>
> Acked-by: Marc Zyngier <marc.zyngier at arm.com>
> ---
>  arch/arm/mach-realview/realview_eb.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/mach-realview/realview_eb.c b/arch/arm/mach-realview/realview_eb.c
> index d3b3cd2..28511d4 100644
> --- a/arch/arm/mach-realview/realview_eb.c
> +++ b/arch/arm/mach-realview/realview_eb.c
> @@ -467,6 +467,7 @@ static void __init realview_eb_init(void)
>  MACHINE_START(REALVIEW_EB, "ARM-RealView EB")
>  	/* Maintainer: ARM Ltd/Deep Blue Solutions Ltd */
>  	.atag_offset	= 0x100,
> +	.smp		= smp_ops(realview_smp_ops),
>  	.fixup		= realview_fixup,
>  	.map_io		= realview_eb_map_io,
>  	.init_early	= realview_init_early,

Please can you put this in the patch system? Mainline is broken on SMP EB
without it.

Will



More information about the linux-arm-kernel mailing list