[PATCH v2] ARM: DTS: CROS5250: Add max77686 device tree support

Abhilash Kesavan kesavan.abhilash at gmail.com
Tue Dec 4 22:08:07 EST 2012


Hi Doug,

[...]
>> +
>> +                               ldo7_reg: LDO7 {
>> +                                       regulator-name = "P1.0V_LDO_OUT7";
>> +                                       regulator-min-microvolt = <1100000>;
>> +                                       regulator-max-microvolt = <1100000>;
>> +                                       regulator-always-on;
>> +                               };
>
> This matches the signal name on the most recent schematics, which is
> good, but I'd be slightly happier if it said "1.1V" in instead of
> 1.0V.  I'd imagine that if we ever rev the schematics that we'd fix
> that.
Will change to 1.1
[...]
> ...would love to see LDO7 name fixed up, but otherwise looks good to
> me.  Thanks!
>
> Acked-by: Doug Anderson <dianders at chromium.org>
Will re-post with your ACK.

Abhilash



More information about the linux-arm-kernel mailing list