[PATCH 1/4] rtc: sa1100: enable/disable rtc when probe/remove the device
Russell King - ARM Linux
linux at arm.linux.org.uk
Mon Dec 3 04:48:29 EST 2012
On Mon, Dec 03, 2012 at 10:53:07AM +0800, Chao Xie wrote:
> I want to correct what i said. For the irq register/unregister i think
> can be done at open/release. But for clock enable/disable, i do not
> think so. If clock is disabled, as i think RTC will not work. User API
> still use open->get_time->close for "date" command. It means that RTC
> will not return correct date to user.
"I think" is not good enough for patches like this. Please test it.
On SA11x0 and PXA platforms, the clock for the sa1100-rtc is a dummy
clock; it has no effect. For MMP, I don't have access to the TRMs so
that's something you're going to have to find out.
More information about the linux-arm-kernel
mailing list