[PATCH 2/4] rtc: pxa: fix rtc caculation issue
xiechao.mail at gmail.com
Sun Dec 2 21:40:53 EST 2012
On Fri, Nov 30, 2012 at 4:04 AM, Robert Jarzmik <robert.jarzmik at free.fr> wrote:
> Chao Xie <chao.xie at marvell.com> writes:
> Hi Chao Xie,
> First of all, could you please send patches from rtc-pxa to me also, as I'm
> maintaining that driver ?
> Second point, the original design of the driver relies on the special case of
> writing zeroes to WOM and DOM, as mentionned in PXA27x Developers Guide, chapter
> 18.104.22.168.5 "Writing Alarm Registers with Invalid (Zero) Data", which states :
>> Day-Of-Week (DOW), or Week-Of-Month (WOM), Day of Month (DOM), Month or Year
>> fields—Zero is not valid for these fields. If zero is written into any of
>> these fields, it is ignored while generating the alarm.
> I'd like to know if your patch fixes something, or is an enhancement ?
> PS: I've not checked the patch yet, that's just a prelimary comment on the patch
I am sorry, i just use get_maintainer.pl to get the "to" list.
I have go through the spec. The spec has the desctiption about the
invalid data writing.
I am a little confused about the "wrting 0 to DOW". The descrption is
confused. first it said that "If zero is written into any of these
fields, it is ignored
while generating the alarm", then it gives a example, that if writing
0 to DOW, "For example, if a zero is written into a DOW field, the
alarm is set
every day at the time written in the Hours, Minutes, and Seconds
field”. It seems that the Year/Month/Week will not take effect.
I will do the test on the board again, and send out the update.
More information about the linux-arm-kernel