Re[2]: [PATCH 1/2] ARM: ixp4xx: Moving the timer flags control in ixp4xx_irq_ack() procedure

[Alexander Shiyan]

> Alexander Shiyan writes:
>  > Rather than modify the EOI flags directly in the timer interrupt,
>  > let's deal with these flags in the ixp4xx_irq_ack() procedure.
> 
> Why?
> 
> All I see is that you're removing simple unconditional code from two
> interrupt handlers and adding a large conditional to ixp4xx_irq_ack,
> which will slow down all interrupt acks.
> 
> So in what way is this an improvement?

This is a right place for do it. Now we can use these interrupts in any
drivers without patching last one for touching ACK.

---